catgirl: Fix off-by-one edge case in macro expansion (patch)

catgirl: Fix off-by-one edge case in macro expansion (patch)

From: Alcor
To: list
Cc: june
Steps to reproduce:

1. Connect to any network (I chose OFTC for this)
2. Switch to the NickServ tab, or simply /QUERY NickServ
3. Type \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ and hit ENTER
4. Type \hug then hit C-x

Expected result:

The macro is expanded.

Observed result:

The macro is not expanded.

Patch / Fix:

macroExpand() contains an off-by-one error. `macro' should be
decremented before doing the backward scan for the macro escape
character in order to ensure that no stale buffer memory is queried
instead.

Attached is a simple fix.

Cheers,